-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to angular 9 #509
Update to angular 9 #509
Conversation
Also temporary installed packages for upgrade (see:angular/angular#35221 (comment))
Preview Environment ready at https://pr-509.demo-phonebook.me |
🤯🤯 Angular 9 |
remove superflous test lang in xliff config
- clean up the redundancy - fix build - fix tests
Preview Environment ready at https://pr-509.demo-phonebook.me |
Preview Environment ready at https://pr-509.demo-phonebook.me |
@T-Systems-MMS/phonebook-developers would you take a look if everything is still working? |
Preview Environment ready at https://pr-509.demo-phonebook.me |
Thats not a problem of this PR but a general Problem. You can find the same problem in the main demo. |
Preview Environment ready at https://pr-509.demo-phonebook.me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe remove empty lines. :) But the rest looks okay 👍
@marcuskrahl Wenn du Zeit hast kannst du gerne einmal drüber schauen. Falls du ein paar Ratschläge für das updaten auf Angular 9 (insbesondere i18n) brauchst schreib mich einfach an. |
Preview Environment ready at https://pr-509.demo-phonebook.me |
@Zeroks77 approve? |
I had a look at every commit except for the one with 15k lines changed for localization. |
🎉 This PR is included in version 1.36.9 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Faster Builds! (Just 76s!) (in the future also only one build instead of 2)
Smaller Files (~20%)
Better translation coming (just not yet, angular team still need time angular/angular-cli#16375)
Till then:
TODO: Localization
--> Remove TODO: Localization #515